#146 Major refactoring; implements Repository Pattern and many more
state: closed opened by: adrianharabula on: 5/27/2017
Comments
from: adrianharabula on: 5/27/2017
Review status: 0 of 46 files reviewed at latest revision, 7 unresolved discussions.
app/app/Characterizable.php, line 0 at r1 (raw file): se pare că nu ne mai trebuie, am simplificat puţin lucrurile
app/app/Product.php, line 6 at r1 (raw file):
use Illuminate\Database\Eloquent\Model;
use Laravel\Scout\Searchable;
aici trebuie să scoatem searchable pentru că folosim alt cod pentru search acum
app/app/Product.php, line 41 at r1 (raw file):
public function characteristics()
{
return $this->belongsToMany(Characteristic::class, 'product_characteristic_vote', 'product_id', 'characteristic_id');
aici avem relaţie many to many cu 3 pivoţi, poduct_id, characteristic_id şi vote_id
app/app/Http/Controllers/ContactFormController.php, line 10 at r1 (raw file):
{
public function getFormController() {
this needs to be completed
app/app/Http/Controllers/ProductsController.php, line 64 at r1 (raw file):
{
return view('product.list')
->with('products',$this->_productRepository->searchProducts($data));
aici avem noul search nativ
app/app/Http/Controllers/StaticPageController.php, line 11 at r1 (raw file):
public function staticPage()
{
return view('static'.request()->route()->getName());
avem aici un controller care procesează paginili statice, nu e nevoie să ai câte un controller pentru fiecare rută statică
app/routes/web.php, line 110 at r1 (raw file):
Route::get('{route}', function ($route) {
return view('static.'.$route);
});
aici nici nu mai avem nevoie de controller pentru routes statice :))
Comments from Reviewable
from: elis47 on: 5/28/2017
Reviewed 1 of 10 files at r2. Review status: 1 of 47 files reviewed at latest revision, 7 unresolved discussions.
Comments from Reviewable
from: elis47 on: 5/28/2017
Reviewed 1 of 59 files at r1. Review status: 2 of 47 files reviewed at latest revision, 7 unresolved discussions.
Comments from Reviewable